Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Switch on aws s3 copy, fix typo #3210

Merged
merged 6 commits into from
Apr 20, 2024
Merged

build: Switch on aws s3 copy, fix typo #3210

merged 6 commits into from
Apr 20, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Apr 19, 2024

Description

Fix
clouldfare -> cloudlfare

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@istarkov istarkov marked this pull request as ready for review April 20, 2024 12:32
@istarkov istarkov requested review from TrySound and kof April 20, 2024 12:32
@istarkov istarkov changed the title build: Fast Deploy Test build: Switch on aws s3 copy, fix typo Apr 20, 2024
@istarkov istarkov merged commit b0a28b8 into main Apr 20, 2024
35 of 38 checks passed
@istarkov istarkov deleted the fast-deploy.staging branch April 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants